Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-remix): Allow private GitHub repos to use the latest release url for tarballs #4329

Merged
merged 7 commits into from
Oct 12, 2022
Merged

fix(create-remix): Allow private GitHub repos to use the latest release url for tarballs #4329

merged 7 commits into from
Oct 12, 2022

Conversation

johnmberger
Copy link
Contributor

@johnmberger johnmberger commented Oct 5, 2022 •
edited
Loading

Closes: #4328

  • Docs
  • Tests

Testing Strategy:

My main mode of testing was to try this out against a private repo with a stack tarball by running these three permutations:

# 🟢  new functionality
npx create-remix ./my-project --template https://github.com/<owner>/<repo>/releases/download/v.1.1/stack.tar.gz --token <my-token>

# 🟢  existing functionality
npx create-remix ./my-project --template https://github.com/<owner>/<repo>/releases/download/<version>/stack.tar.gz --token <my-token>

# 🔴 using a non-existent version (should fail)
npx create-remix ./my-project --template https://github.com/<owner>/<repo>/releases/download/<bad version>/stack.tar.gz --token <my-token>

# Verify all existing tests pass
yarn test

I attempted unsuccessfully to unit test this, but without spending much more time mocking out github api calls, I wasn't able to write anything worthwhile... happy to revisit if you disagree! I also cleaned up a tertiary test to make more sense.

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 8294405

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 5, 2022

Hi @johnmberger,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 5, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@mcansh mcansh linked an issue Oct 12, 2022 that may be closed by this pull request
Private GitHub stack templates don't work with the releases/latest/download/{filename} url structure #4328
Closed
@mcansh mcansh changed the title Allow private GitHub repos to use the latest release url for tarballs fix(create-remix): Allow private GitHub repos to use the latest release url for tarballs Oct 12, 2022
@mcansh mcansh merged commit 833dcac into remix-run:dev Oct 12, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-eebaa56-20221013 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour left review comments

@mcansh mcansh mcansh approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private GitHub stack templates don't work with the releases/latest/download/{filename} url structure
3 participants
@johnmberger @machour @mcansh